EZP-29322: As an editor I want to use translated Admin panel #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
adamwojs
approved these changes
Jun 26, 2018
bdunogier
approved these changes
Jun 26, 2018
|
By the way, I'd change the pull-request's title so that it describes what this particular PR does (instead of the story's title). A short description (2, 3 sentences) also helps reviewers and those who follow pull-requests. |
mikadamczyk
force-pushed
the
EZP-29322
branch
2 times, most recently
from
242dad4
to
19f4338
Compare
ViniTou
approved these changes
Jun 27, 2018
|
It was reported in EZP-29377 that in some cases, the english translation won't be picked up. I think it's because I suggest that we fix it by always adding |
|
+1 @bdunogier, also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterrefers to ezsystems/ezplatform-admin-ui#532
TODO:
$ composer fix-cs).