EZP-30029: As a Developer I'd like API for bulk loading Content Info Items #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 task
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4 tasks
This comment has been minimized.
This comment has been minimized.
andrerom
force-pushed
the
bulk_load_content_info_api
branch
from
1f4355a
to
e66cb0c
Compare
adamwojs
approved these changes
Feb 1, 2019
andrerom
force-pushed
the
bulk_load_content_info_api
branch
from
e66cb0c
to
cf7b695
Compare
alongosz
approved these changes
Feb 6, 2019
|
Merging as this is only for sanity checks anyway and hence will be tested as part of 2.5 certification, also I need this for upcoming PR also to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterIn order to optimize logic in RelationList/ParameterProvider, and other places eventually.
TODO:
$ composer fix-cs).Design:
public function loadContentInfoList(array $contentIds, bool $filterOnUserPermissions = true): iterable;REVIEW NOTE*
I'm not sold on addingbool $filterOnUserPermissionsparam myself, but it aligns withSearchService, and it also fits well withloadContentListByContentInfowhich explicitly does not check permissions as it expects that to already have been done on provided content info.