Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30367: Error: Location cannot be displayed as it is flagged as invisible. #2590

Merged
merged 1 commit into from
Apr 8, 2019
Merged

EZP-30367: Error: Location cannot be displayed as it is flagged as invisible. #2590

merged 1 commit into from
Apr 8, 2019

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Mar 28, 2019 •
edited
Loading

Question Answer
JIRA issue EZP-30367
Bug/Improvement yes
New feature no
Target version 7.4
BC breaks no
Tests pass yes
Doc needed no

ezsystems/ezplatform-admin-ui#936

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@ViniTou ViniTou mentioned this pull request Mar 28, 2019
Merged
2 tasks
@ViniTou ViniTou force-pushed the EZP-30367-hidden-root-viewlocation-path branch from 1590f0a to 954fa8e Compare April 2, 2019 13:31
@ViniTou ViniTou changed the title [WIP] EZP-30367: Error: Location cannot be displayed as it is flagged as invisible. EZP-30367: Error: Location cannot be displayed as it is flagged as invisible. Apr 4, 2019
@alongosz
Copy link
Member

alongosz commented Apr 4, 2019

Seems to me that due to changes in ezsystems/ezplatform-admin-ui#936 you don't need these changes. What am I missing? :)

@ViniTou
Copy link
Contributor Author

ViniTou commented Apr 4, 2019 •
edited
Loading

Inside loadLoaction there is

 if ($location->invisible) {
            throw new HiddenLocationException($location, 'Location cannot be displayed as it is flagged as invisible.');
        }

So, now from adminUI I provide locationId and location. And since locationId is checked first it fails at above condition.
Also it seems kinda strange to try to load location again when it is already provided, but that could also be related to above ¯\_(ツ)_/¯

@ViniTou ViniTou requested a review from alongosz April 5, 2019 09:49
@ViniTou ViniTou changed the base branch from master to 7.4 April 5, 2019 09:52
@ViniTou ViniTou force-pushed the EZP-30367-hidden-root-viewlocation-path branch from b9ab78b to 5f83dd1 Compare April 5, 2019 09:53
@ViniTou ViniTou force-pushed the EZP-30367-hidden-root-viewlocation-path branch from 5f83dd1 to e325e77 Compare April 5, 2019 09:54
@barbaragr barbaragr self-assigned this Apr 8, 2019
@lserwatka lserwatka merged commit 0af35d2 into ezsystems:7.4 Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

@barbaragr barbaragr barbaragr approved these changes

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@barbaragr barbaragr

Labels
Ready for QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ViniTou @alongosz @adamwojs @mikadamczyk @barbaragr @lserwatka