Fix EZP-23057: viewContent does not set the X-Location-Id

[dpobel]

JIRA: https://jira.ez.no/browse/EZP-23057

Description

The view content action in the view controller does not set the X-Location-Id header preventing the cache from being purged!

(Bug reported by @pborreli)

Tests

manual test

[gggeek]

A small update to phpdoc above?

[andrerom]

Was it intended to set X-Content-Id perhaps when multi id support will be added?

[joaoinacio]

Q: What about secondary locations?

[andrerom]

A: cache code should purge on all locations currently afaik.

[lolautruche]

+1

[andrerom]

+1

[joaoinacio]

Untested, but wouldn't there be problems with custom requests, varnish etc?
Use case:

• Content A, Locations 100 and 200
• Render location 200, receive X-Location-Id: 100
• Cannot purge location 200

[andrerom]

This is viewContent, not viewLocation. But ideally this should set Content-id instead.

[gggeek]

Right now when content is edited, it sends purge commands with all locations, so it will expire correctly viewContent as well.
Otoh custom code which only triggers an expiry using id of location B will not get the ViewContent cache to expire as well.

@andrerom are you suggesting we add a new header X-Content-Id and use it for cache expiration?
It might make sense, as we'd reduce the number of cached items tied to a single location-id (and Sf is already pushed to its limits by eZ5, according to implementors feedback).
Otoh it would mean that we have to send 1 more purge request on each content edit

[andrerom]

I was implying multi id (Content, ContentType, Section...) support yes, and afaik this is planned to be solved in FOSHTTPCacheBundle which we intend to adopt over the summer.

[pborreli]

@gggeek right now, the purge only invalidates page with an actual X-Location-Id header as it purges X-Location-Id: *

[andrerom]

(and Sf is already pushed to its limits by eZ5, according to implementors feedback).

yes, but high traffic multi frontend is supposed to be handled with Varnish. A hammer works badly as a heavy duty breaker.. :)

[andrerom]

Issue tagged to also be back ported to 5.3.2

[pborreli]

@andrerom will it be included in next release 2014.05.01?