Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing search in media lib which used to loose context #1433

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

pkamps
Copy link
Contributor

@pkamps pkamps commented May 24, 2019

Background
Media content search results through embedded browse on admin site looses "media" context upon pagination and returns much larger search result.

Testing instructions

  • In the media lib, do a search that returns more that one page of result sets (you may need to create some dummy content for that)
  • On that result set, click on page 2
  • Confirm you are still showing result sets in context of only the media lib
    (Without this pull request, you would be in the context of the 'Content Structure' and it would potentially return more result entries)

@andrerom andrerom requested a review from glye November 1, 2019 12:43
@andrerom andrerom changed the base branch from master to 2019.03 November 1, 2019 14:59
@andrerom andrerom merged commit 4f9d556 into ezsystems:2019.03 Nov 1, 2019
Opencontent pushed a commit to Opencontent/ezpublish-legacy that referenced this pull request Mar 17, 2020
* commit 'c49eef93f50c665a3d7a6b2aa6387ccd46e059f5':
  Removed invalid constructor call
  Fixed wrong old-style constructor usage
  EZP-31040: Remote Code Execution in file uploads
  Show images after used url_prefix (ezsystems#1453)
  improve php 7 bc doc (ezsystems#1452)
  Fix notice when checking for anonymous  classes in autoload generator (ezsystems#1450)
  Do not support literal HTML in the Administration Interface (ezsystems#1408)
  Fix transformURI() on ignoreIndexDir & ! htmlEscape (ezsystems#1449)
  Make autoloads ignore anonymous classes (ezsystems#1448)
  Update php7.md
  Fixing search in media lib which used to loose context (ezsystems#1433)
  [Travis] Add testing for PHP 7.2 and 7.3 (ezsystems#1446)
  EZP-30834: remove strtotime function from the trashed-days option (ezsystems#1441)
  Fix instances of count() that would cause a warning in 7.2
  Updated dbupdate scripts so they will no longer fail when there are multiple users with the same e-mail (ezsystems#1445)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants