Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Travis] Add testing for PHP 7.2 and 7.3 #1446

Merged
merged 3 commits into from
Nov 1, 2019
Merged

[Travis] Add testing for PHP 7.2 and 7.3 #1446

merged 3 commits into from
Nov 1, 2019

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented Nov 1, 2019

No description provided.

@andrerom andrerom mentioned this pull request Nov 1, 2019
Closed
@gggeek
Copy link
Contributor

gggeek commented Nov 1, 2019

Not sure if it's relevant here - possibly the ezp legacy test suite is tightly coupled to phpunit version 4, but I had good success running unit tests with different phpunit versions to achieve compatibility with php 5.6 => 7.3 using version constraint "phpunit/phpunit": "^5.7 || ^7.5" `

@andrerom
Copy link
Contributor Author

andrerom commented Nov 1, 2019 •
edited
Loading

I had good success running unit tests with different phpunit versions to achieve compatibility with php 5.6 => 7.3 using version constraint "phpunit/phpunit": "^5.7 || ^7.5" `

Was that on ezpublish-legacy? that would be relevant, or are you talking about another package?

@gggeek
Copy link
Contributor

gggeek commented Nov 1, 2019

^^ nopes, other project

@andrerom
Copy link
Contributor Author

andrerom commented Nov 1, 2019 •
edited
Loading

ok, well seems travis is ok with this so we just got testing up and running for 7.2/7.3 🎉

NOTE: There are deprecation messages coming from phpunit code over each() usage, but they don't interfere with the test run and results so I deemed this good enough for now.

If anyone wants to take this further to fix that, this might be relevant:
I did check how much work it would be to use symfony/phpunit-bridge, but we will need to change to use xml suites and several other changes in order to be able to run tests via it from what I could see, this will affect extensions with tests as well.

@andrerom andrerom merged commit 6b639ac into 2019.03 Nov 1, 2019
@andrerom andrerom deleted the test_php7.3 branch November 1, 2019 12:41
@pkamps pkamps mentioned this pull request Dec 5, 2019
Merged
Opencontent pushed a commit to Opencontent/ezpublish-legacy that referenced this pull request Mar 17, 2020
@lrealdi
Merge commit 'c49eef93f50c665a3d7a6b2aa6387ccd46e059f5' into temp
69230ac 
* commit 'c49eef93f50c665a3d7a6b2aa6387ccd46e059f5':
  Removed invalid constructor call
  Fixed wrong old-style constructor usage
  EZP-31040: Remote Code Execution in file uploads
  Show images after used url_prefix (ezsystems#1453)
  improve php 7 bc doc (ezsystems#1452)
  Fix notice when checking for anonymous  classes in autoload generator (ezsystems#1450)
  Do not support literal HTML in the Administration Interface (ezsystems#1408)
  Fix transformURI() on ignoreIndexDir & ! htmlEscape (ezsystems#1449)
  Make autoloads ignore anonymous classes (ezsystems#1448)
  Update php7.md
  Fixing search in media lib which used to loose context (ezsystems#1433)
  [Travis] Add testing for PHP 7.2 and 7.3 (ezsystems#1446)
  EZP-30834: remove strtotime function from the trashed-days option (ezsystems#1441)
  Fix instances of count() that would cause a warning in 7.2
  Updated dbupdate scripts so they will no longer fail when there are multiple users with the same e-mail (ezsystems#1445)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@andrerom @gggeek