EZP-29953: Do not support literal HTML in the Administration Interface #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterkeung
changed the title
andrerom
approved these changes
Dec 18, 2019
emodric
approved these changes
Dec 18, 2019
Opencontent
pushed a commit
to Opencontent/ezpublish-legacy
that referenced
this pull request
Mar 17, 2020
* commit 'c49eef93f50c665a3d7a6b2aa6387ccd46e059f5': Removed invalid constructor call Fixed wrong old-style constructor usage EZP-31040: Remote Code Execution in file uploads Show images after used url_prefix (ezsystems#1453) improve php 7 bc doc (ezsystems#1452) Fix notice when checking for anonymous classes in autoload generator (ezsystems#1450) Do not support literal HTML in the Administration Interface (ezsystems#1408) Fix transformURI() on ignoreIndexDir & ! htmlEscape (ezsystems#1449) Make autoloads ignore anonymous classes (ezsystems#1448) Update php7.md Fixing search in media lib which used to loose context (ezsystems#1433) [Travis] Add testing for PHP 7.2 and 7.3 (ezsystems#1446) EZP-30834: remove strtotime function from the trashed-days option (ezsystems#1441) Fix instances of count() that would cause a warning in 7.2 Updated dbupdate scripts so they will no longer fail when there are multiple users with the same e-mail (ezsystems#1445)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many sites support literal HTML for front-end sites. However, we have found this to be nothing but damaging for the Administration Interface, whether that's JavaScript breaking the functionality or CSS breaking the layout. The simple fix is to disable support for the "html" literal tag class in the Administration Interface.