Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Application Default Credentials #13

Open
zudov opened this issue Sep 25, 2017 · 4 comments
Open

Support Application Default Credentials #13

zudov opened this issue Sep 25, 2017 · 4 comments

Comments

@zudov
Copy link
Collaborator

zudov commented Sep 25, 2017

https://developers.google.com/identity/protocols/application-default-credentials

@f-f
Copy link
Owner

f-f commented Sep 27, 2017

I read this through, and it looks like to support the whole flow of auto-autentication for all the environments we need to pull in the SDK for one of the supported languages (Java in this case), which I'm not sure it's a dependency we want to depend on (as it is a client on its own already).

On the bright side, supporting the reading of the service account key from the path provided in the env variable GOOGLE_APPLICATION_CREDENTIALS should be straightforward to implement.

@f-f
Copy link
Owner

f-f commented Sep 27, 2017

@zudov given the previous comment, is fc701a7 enough to consider this closed?

@f-f f-f added the auth label Sep 28, 2017
@zudov
Copy link
Collaborator Author

zudov commented Sep 29, 2017

Yep. Just a variable would do good for now. Doesn't feel good to pull the java SDK dependency for just that (given that otherwise we can be free of it). So maybe when the time is good we just implement the full "Application default credentials" in clojure and have it in another library. They've got implementations in quite many languages there, so shouldn't be hard to figure it out.

Dunno if we should close this issue. It's "solved" for now, but there's more work to be done. We can either keep it open, or close it and reopen later, or put it into some "production ready" milestone.

@f-f
Copy link
Owner

f-f commented Sep 29, 2017

Sounds good, implementing the full "Application Default Credentials" thing in Clojure shouldn't be too complicated, porting their implementation from Java looks quite feasible.

Let's have this issue open, but add a label for denoting the "not a priority" status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants