Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the dependency intl required for cider? #34

Closed
zeshuaro opened this issue Dec 16, 2022 · 1 comment · Fixed by #35
Closed

Is the dependency intl required for cider? #34

zeshuaro opened this issue Dec 16, 2022 · 1 comment · Fixed by #35

Comments

@zeshuaro
Copy link
Contributor

I'm trying to upgrade the dependency intl from 0.17.0 to 0.18.0 in my project. But I'm getting a version resolve conflict because cider currently depends on intl: ^0.17.0.

Initially, I was going to ask if you can bump the intl dependency to 0.18.0. However, after looking at the code, it doesn't seem like it's used/imported anywhere.

So now my question is can this dependency be removed from cider?
@f3ath
Copy link
Owner

f3ath commented Dec 16, 2022

Can you try removing it and running the tests please?

@zeshuaro zeshuaro mentioned this issue Dec 16, 2022
Merged
@f3ath f3ath closed this as completed in #35 Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused dependency intl
2 participants
@f3ath @zeshuaro