Remove lifetimes from Database and Collection #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also pretty much fix the problems in #10, since everything is |
Removes the phantom lifetime field from Database and Collection. These fields apparently do not add any value, and make working with the API quite a lot more cumbersome.
fMeow
added a commit
that referenced
this pull request
Jul 26, 2020
### Features
* Add QueryBuilder::try_bind (#25) (bbe2941)
* Remove lifetimes from Database and Collection (#23) (222445e)
* return CollectionType instead of a reference (b46c832)
### BREAKING CHANGES
* return CollectionType instead of reference
for Collection::collection_type()
* Removes the phantom lifetime field from Database and Collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the phantom lifetime field from Database and Collection.
These fields apparently do not add any value, and make working with the
API quite a lot more cumbersome.