Support to run ImageMagick #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
commented
Oct 7, 2022
| @@ -4,6 +4,20 @@ | |||
| #include <unordered_map> | |||
| #include <vector> | |||
|
|
|||
| #define FAKE_NAME "faasm" | |||
There was a problem hiding this comment.
Moving these definitions to a header where all runtimes can benefit from them.
csegarragonz
commented
Oct 7, 2022
| REG_NATIVE_FUNC(__wasi_fd_dup, "(i*)i"), | ||
| REG_NATIVE_FUNC(dup, "(i)i"), | ||
| REG_NATIVE_FUNC(tempnam, "(ii)i"), | ||
| REG_NATIVE_FUNC(__wasi_fd_dup, "(i*)i"), REG_NATIVE_FUNC(dup, "(i)i"), |
There was a problem hiding this comment.
Weird formatting by clang-format here.
Shillaker
approved these changes
Oct 12, 2022
.github/workflows/tests.yml
Outdated
| @@ -64,6 +64,12 @@ jobs: | |||
| - name: "Build libfake" | |||
| run: ./bin/inv_wrapper.sh libfake | |||
| working-directory: ${{ github.workspace }}/clients/cpp | |||
| - name: "Update ImageMagick submodule" | |||
| run: git submodule update --init -f third-party/ImageMagick | |||
| working-directory: ${{ github.workspace }}/clients/cpp | |||
There was a problem hiding this comment.
Why do we need to update the ImageMagick submodule here? We're checking out the code with submodules: true which should do this implicitly.
csegarragonz
force-pushed
the
image
branch
2 times, most recently
from
ae549a3
to
7cc2193
Compare
|
This should be good to go after #688 is merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I include support to run ImageMagick in WAVM, and WAMR. The SGX PR will follow, as it is larger in size.
I also add a test that takes a sample image and flips it. I use Faasm's logo as test image.