Fixes to CI/CD #688
Merged
Fixes to CI/CD #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
approved these changes
Oct 25, 2022
eigenraven
reviewed
Oct 25, 2022
.github/workflows/tests.yml
Outdated
| with: | ||
| directory: /usr/local/code/faasm | ||
| - name: "Build dev dependencies to be shared by all runs" | ||
| run: ./bin/inv_wrapper.sh dev.cmake --build Debug |
There was a problem hiding this comment.
Without running CMake this job becomes useless, the cache action only sets up the cache, while cmake populates it when it runs conan install during configuration.
There was a problem hiding this comment.
Thats a good point, thanks for bringing this up. The reason I removed it in the first place was because the CMakeCache would point to a different directory as actions/checkout check the code out somewhere else (so we needed the --clean and I thought that if we were to build with --clean then we might as well do it just once) but you are right.
csegarragonz
force-pushed
the
python-format
branch
from
1fc860a
to
98b4d97
Compare
csegarragonz
force-pushed
the
python-format
branch
from
98b4d97
to
5efea7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3/3 of this PR. See faasm/faabric#279 for background.
Closes #687