Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@fab/deployer-aws-*] Credential Sourcing #180

Closed
thejuan opened this issue May 20, 2020 · 2 comments
Closed

[@fab/deployer-aws-*] Credential Sourcing #180

thejuan opened this issue May 20, 2020 · 2 comments

Comments

@thejuan
Copy link
Contributor

thejuan commented May 20, 2020 •
edited
Loading

AWS SDK already has a pattern for sourcing credentials
https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/setting-credentials-node.html

By explicitly forcing users to provide key and secret you break the other flows such as AWS_PROFILE

Work around is to use a thirdparty cli tool for generating temp creds before hand such as https://www.npmjs.com/package/aws-assume for legacy apps

Edit: Get a token invalid error using the above, had to monkey patch
@thejuan
Copy link
Contributor Author

thejuan commented May 20, 2020

Once I'm up and running, will look at PR

@thejuan thejuan changed the title AWS Credential Sourcing [@fab/deployer-aws-*] Credential Sourcing May 20, 2020
This was referenced May 20, 2020
Closed
Merged
@geelen
Copy link
Contributor

geelen commented Jun 9, 2020 •
edited
Loading

Fixed in #182

@geelen geelen closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geelen @thejuan