Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAB Next.js build doesn't respect Next Build Configuration #348

Open
thejuan opened this issue Feb 17, 2021 · 5 comments
Open

FAB Next.js build doesn't respect Next Build Configuration #348

thejuan opened this issue Feb 17, 2021 · 5 comments

Comments

@thejuan
Copy link
Contributor

thejuan commented Feb 17, 2021

There are a few seperate issues related to this
#331
#301

The latest issue is we are using local ESM modules that get transpiled via next config using next-transpile-modules plugin.

FAB seems to bring in the transpiled and non-transpiled version of the library into server.js, but only the transpiled version is in the next.js generated code

@geelen
Copy link
Contributor

geelen commented Feb 17, 2021

Wow that's really strange, I don't know why the FAB compiler would be doing that.

How easy is it to reproduce? I'd like to look at the .next/serverless directory to see what's in there. As far as I remember, that's the only place FAB looks for stuff...

@thejuan
Copy link
Contributor Author

thejuan commented Feb 17, 2021

I'll try get a repo up tomorrow. I also realised the offending imported code is maybe coming from plugins, may make a difference?

@thejuan
Copy link
Contributor Author

thejuan commented Feb 17, 2021

@geelen
Copy link
Contributor

geelen commented Feb 18, 2021

Ah I think you've not yet added me as a collaborator?

@thejuan
Copy link
Contributor Author

thejuan commented Feb 18, 2021

Fixed. Its public now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants