Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 support #5

Closed
edhelas opened this issue Dec 3, 2019 · 3 comments
Closed

PHP 7.4 support #5

edhelas opened this issue Dec 3, 2019 · 3 comments

Comments

@edhelas
Copy link

edhelas commented Dec 3, 2019

It seems that the lib is failing with PHP7.4

PHP Warning:  file_get_contents(): stream does not support seeking in /var/www/html/movim/vendor/fabiang/sasl/src/Authentication/AbstractAuthentication.php on line 92
PHP Warning:  file_get_contents(): Failed to seek to position -1 in the stream in /var/www/html/movim/vendor/fabiang/sasl/src/Authentication/AbstractAuthentication.php on line 92

I was able to fix the issue by replacing

return base64_encode(file_get_contents($file, false, null, -1, 32));

with

return base64_encode(file_get_contents($file, false, null, 0, 32));

In the file.
I'd be pleased if you can release this fix :)

@fabiang fabiang closed this as completed in 10c3f75 Dec 3, 2019
@fabiang
Copy link
Owner

fabiang commented Dec 3, 2019

Seems to me I've used the wrong default parameter for the $seek parameter there. Fixed in master an tagged a v1.0.1.

@edhelas
Copy link
Author

edhelas commented Dec 3, 2019

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants