feature: define blog slug in frontmatter #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify gatsby-node.js that reads in frontmatter slug and uses it for blog URL. If frontmatter is not defined or slug is not defined it will default to file path for slug.
fabien0102
requested changes
Feb 15, 2018
gatsby-node.js
Outdated
| @@ -36,9 +36,10 @@ exports.onCreateNode = ({node, boundActionCreators, getNode}) => { | |||
| let slug; | |||
| switch (node.internal.type) { | |||
| case `MarkdownRemark`: | |||
| const fmSlug = (node.frontmatter && node.frontmatter.slug) ? node.frontmatter.slug : false | |||
There was a problem hiding this comment.
Here you can use get from lodash (https://lodash.com/docs/4.17.5#get), and I prefer long variable name instead of acronyms 😉
const frontmatterSlug = get(node, 'frontmatter.slug');
|
@jkornblum carefull you miss a semi-column ^^ You can run |
|
Thanks for feedback. I tried the one liner without the checks! I was burned 😄 Anyways I updated and cleaned up code, added unit test, and changed one markdown file use the frontmatter slug. Let me know if it looks okay. |
|
It looks good, I just need to check why netlify don't want to deploy ^^ Strange… I look this after, really thank you for your PR 👍 |
fabien0102
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
gatsby-node.jsso that it reads in frontmatter slug and uses it for blog URL. If frontmatter is not defined or slug is not defined it will default to file path for slug (current behavior).E.g. on the demo the first blog post is
demo.com/blog/2017-04-18--welcoming/by addingslugto front matter likethe new url would be
demo.com/blog/2017-04-18/my-article