-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #89
Conversation
I'm sorry I haven't done this in a while, I probably should have submitted this pull request on a branch. Still attempting to squash the errors on my side. I was able to update storybook and webpack, and add the missing peer dependencies with safer security-audit-passing versioning. |
Deploy preview for fabien0102-gatsby-starter ready! Built with commit d10b06c https://deploy-preview-89--fabien0102-gatsby-starter.netlify.com |
@bensontrent Don't worry, your repo (even on master) is still a branch from this perspective 😉 Thanks for your contribution, just waiting that everything is green to be able to merge 💯 |
I still have one test that needs to be corrected to satisfy the updated Jest package and node. The |
This PR is ready to go on my side. Let me know if you'd like this in a branch rebased on master. |
Currently you can't create a new project from this starter because of these dependency issues. Is this going to make it in? |
@fabien0102 I'm assuming you just haven't had the time to consider this PR or perhaps hesitant to check this in since I had to modify some of the tests. The tests were designed for an earlier version of Gatsby; I had to update them to conform with the output generated by the newer version of Gatsby and the updated dependencies. @jspizziri you can try building from my working branch: Run: However, I don't intend to keep that branch maintained, so make a note to yourself to merge in with the main fabien0102:master source down the road. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Sorry for the delay, I don't really have time for this side project anymore and I saw the last notification 😬
@bensontrent Thanks for your contribution 💯 If you are interested, I'm still looking for more contributor/maintainer. I don't really have time to maintain this project anymore (a lot of other sideproject and I don't use gatbsy currently). |
@fabien0102 sure I'm happy to help out. I'm not sure how much I will contribute either but at least I can keep an eye on it. Gatsby needs a good Typescript starter project and this is it. |
@bensontrent Totally agreed with the needs of a good Typescript starter! You are now an official contributor 😃 Welcome to the team 🎉 |
Updated dependencies and removed
next
version numbers as these no longer exist to enable a successfulnpm install
.