Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping - updates & fixes #96

Merged
merged 11 commits into from
Dec 14, 2019
Merged

Conversation

jamestharpe
Copy link
Contributor

  • Fixes spelling of "programmatically"
  • Replaces "precommit" npm script with "husky" config to remove warning
  • Multiple package version upgrades to resolve security warnings and issues running on Windows
  • Add "remark-frontmatter" dependency to resolve build error

@jamestharpe
Copy link
Contributor Author

Hi @fabien0102 - just wanted to say THANK YOU for putting this starter together, I really like it!

I had some trouble getting up-and-running, but everything is now looking good and this pull request resolves all the issues I had. I hope you find it useful!

@jamestharpe
Copy link
Contributor Author

Not sure why deploy/netlify failed - the log shows no errors. Maybe it timed out? LMK if I can troubleshoot somehow.

@fabien0102
Copy link
Owner

Let's try to retry the build, no obvious errors indeed (at least from now ^^)

@fabien0102
Copy link
Owner

image

Some unused variables 😬 Normally the logs are public, @jamestharpe tell me if not so I will paste the beast here ^^

(sorry by advance if I'm not very reactive, it's totally the rush at my job 😅)

@jamestharpe
Copy link
Contributor Author

I fixed what I could glean from the logs, but it's failing w/ out error again :-\

Can you tell me what command is failing and I'll take care of it locally?

@fabien0102
Copy link
Owner

Let's try to re-build… 😕

@fabien0102
Copy link
Owner

ok… I will try to build locally to see

@fabien0102
Copy link
Owner

of course, everything works locally… 🤔

@fabien0102
Copy link
Owner

Let's retry with npm instead of yarn, maybe, I hate when netlify crash like this!

@fabien0102
Copy link
Owner

image

YES! I may have something, try to run yarn storybook:build, it's failing locally and netlify also built it

@jamestharpe
Copy link
Contributor Author

Ah, okay - hadn't tested that command! I don't know much about storybook, but I'll see what I can do.

@jamestharpe
Copy link
Contributor Author

I think I fixed it after going down a bit of a rabbit hole (we'll see when the build finishes!). storybook wasn't compatible with version of TypeScript that was being installed, so I updated TypeScript which required storybook to be recompiled. I ended up needing to run npm install -g --production windows-build-tools then npn rebuild to recompile storybook, at which point the npm run storybook:build succeeded.

@fabien0102
Copy link
Owner

fabien0102 commented Nov 29, 2019

Deploy preview for fabien0102-gatsby-starter ready!

Built with commit 9752661

https://deploy-preview-96--fabien0102-gatsby-starter.netlify.com

@jamestharpe
Copy link
Contributor Author

Found an issue when serving the storybook - next push will contain the fix.

@jamestharpe
Copy link
Contributor Author

Anything else I can do for this PR?

@fabien0102
Copy link
Owner

Looks good!

@fabien0102 fabien0102 merged commit 0d3e254 into fabien0102:master Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants