-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping - updates & fixes #96
Conversation
jamestharpe
commented
Nov 27, 2019
- Fixes spelling of "programmatically"
- Replaces "precommit" npm script with "husky" config to remove warning
- Multiple package version upgrades to resolve security warnings and issues running on Windows
- Add "remark-frontmatter" dependency to resolve build error
Hi @fabien0102 - just wanted to say THANK YOU for putting this starter together, I really like it! I had some trouble getting up-and-running, but everything is now looking good and this pull request resolves all the issues I had. I hope you find it useful! |
Not sure why |
This reverts commit eac5cc4.
Let's try to retry the build, no obvious errors indeed (at least from now ^^) |
Some unused variables 😬 Normally the logs are public, @jamestharpe tell me if not so I will paste the beast here ^^ (sorry by advance if I'm not very reactive, it's totally the rush at my job 😅) |
I fixed what I could glean from the logs, but it's failing w/ out error again :-\ Can you tell me what command is failing and I'll take care of it locally? |
Let's try to re-build… 😕 |
ok… I will try to build locally to see |
of course, everything works locally… 🤔 |
Let's retry with npm instead of yarn, maybe, I hate when netlify crash like this! |
Ah, okay - hadn't tested that command! I don't know much about storybook, but I'll see what I can do. |
Also fix linting issues
I think I fixed it after going down a bit of a rabbit hole (we'll see when the build finishes!). |
Deploy preview for fabien0102-gatsby-starter ready! Built with commit 9752661 https://deploy-preview-96--fabien0102-gatsby-starter.netlify.com |
Found an issue when serving the storybook - next push will contain the fix. |
Anything else I can do for this PR? |
Looks good! |