Optional @ApiObjectField name #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2014 15:34
Added optional name to ApiObjectField with default to empty string.
REST names don't always match the Java standard naming convention. As such you should be able to optionally set the name. In the absence of the name it should default to the field name.
|
Merged but I had to fix compilation errors and add unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REST attribute names aren't always the same as the names given in to the object attributes in Java format. For example quite a few people will use Jackson or similar to use JS notation instead of camel.
private String fooBaa;
might be represented in JSON as foo_baa.
I've added an optional name parameter to the @ApiObjectField notation. If a new name is specified it will override the default name otherwise it will simply default back to the actual name.