Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

the spring-boot sample doesn't get any labels or selectors generated #72

Closed
jstrachan opened this issue Jun 2, 2016 · 0 comments
Closed

Comments

@jstrachan
Copy link
Contributor

jstrachan commented Jun 2, 2016

e.g. after a local build:

cd sample/spring-boot
mvn clean compile
cat target/classes/META-INF/fabric8/spring-boot-web-rs.yml

generates

---
apiVersion: "extensions/v1beta1"
kind: "ReplicaSet"
metadata:
  name: "spring-boot-web"
spec:
  replicas: 1
  template:
    metadata: {}
    spec:
      containers:
      - env:
        - name: "KUBERNETES_NAMESPACE"
          valueFrom:
            fieldRef:
              fieldPath: "metadata.namespace"
        image: "fabric8/spring-boot-web:3.0-SNAPSHOT"
        imagePullPolicy: "IfNotPresent"
        name: "fabric8-spring-boot-web"
        ports:
        - containerPort: 8080
          protocol: "TCP"
        securityContext:
          privileged: false
rhuss added a commit to rhuss/fabric8-maven-plugin that referenced this issue Jun 2, 2016
We need to extend the abstraction to allow a preEnriching() to build up default objects and a postEnriching() to customize after the label / annotation enricher has been called. Need to think about it, in order to make it not too complicated.

Fixes fabric8io#72
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant