-
Notifications
You must be signed in to change notification settings - Fork 504
chaos monkey should work without hubot running; it can just not notify a chat room if there's no hubot service running #4647
Comments
I tried to run the chaos monkey as a standalone replication controller in our kubernetes stack without any other fabric8 components:
When the docker container starts, I get the following exception:
Is this related to the missing hubot service? Not sure about this as I don't pass any ENV vars. |
yeah - thats the missing Hubot service; the error should be a bit more clear which service is missing ;) Lets try fix that error message too! |
This is the injection we should make optional so that the HubotNotifier is a NOOP if folks are not running it: |
I think it should default to logging messages to stdout and only optional to hubot, so log collection services can pick up the work done by this chaos monkey. |
@bkonetzny agreed! |
I raised a separate issue for the error message being confusing to not list the missing service: #4648 |
As mentioned in #4648 the error message doesn't have to do with service availability but with a bug in the client lookup. In any case, I added support for Instance injection, which allows handling of optional dependencies. |
now lemme make hubot-notifier agnostic on whether hubot is running or not... |
…ected and used; even if no hubot REST service is running (and log a warning, otherwise keep running and log the chat messages that would have been sent)
…hen hubot is running; plus when its not running and just log a warning on startup along with using standard output
No description provided.
The text was updated successfully, but these errors were encountered: