Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve draw.* usability #66

Closed
4 tasks done
fabrice-rossi opened this issue Oct 9, 2023 · 0 comments · Fixed by #74
Closed
4 tasks done

Improve draw.* usability #66

fabrice-rossi opened this issue Oct 9, 2023 · 0 comments · Fixed by #74
Labels
improvement
Milestone
0.3.0

Comments

@fabrice-rossi
Copy link
Owner

fabrice-rossi commented Oct 9, 2023 •
edited
Loading

The draw.* functions can be improved using different approaches:

  • With better defaults. We do not need p values in general, for instance.
  • By the use of UTF8 characters. We can take inspiration from the tree rendering in https://github.com/r-lib/cli. This could be at least an option or one of the default configuration obtained easily from draw_control().
  • By removing logistic models when possible. In some cases, logistic models are completely pruned in numerous contexts. Rather than reporting them as models, we could display the conditional distribution (as it is constant).
  • By providing a latex output. The ascii/UTF8 representation of context trees is not satisfactory for a latex export. It would be interesting to leverage e.g. the forest package.
@fabrice-rossi fabrice-rossi added this to the 0.3.0 milestone Oct 29, 2023
@fabrice-rossi fabrice-rossi changed the title Use UTF8 characters in draw Improve draw.* usability Nov 20, 2023
fabrice-rossi added a commit that referenced this issue Mar 13, 2024
@fabrice-rossi
Remove p values from the default draw of covlmc (issue #66).
db1a317
fabrice-rossi added a commit that referenced this issue Mar 13, 2024
@fabrice-rossi
Exposed the level_sep parameter and changed its default value (issue #66
961aeb9 
).
fabrice-rossi added a commit that referenced this issue Mar 13, 2024
@fabrice-rossi
Improve time_sep default value and usage (issue #66).
fafd411
fabrice-rossi added a commit that referenced this issue Mar 13, 2024
@fabrice-rossi
Use a specific separator between the intercept and other coefs (issue #…
1c5b9f6 
…66).
fabrice-rossi added a commit that referenced this issue Mar 13, 2024
@fabrice-rossi
Add delimiters around p-values (issue #66).
559f4b8
fabrice-rossi added a commit that referenced this issue Mar 13, 2024
@fabrice-rossi
Enable simplified constant model representation (issue #66).
a52987a
fabrice-rossi added a commit that referenced this issue Mar 22, 2024
@fabrice-rossi
Move the digits parameter from draw.covlmc() to draw_control() Issue #66
7e969c9 
.
fabrice-rossi added a commit that referenced this issue Mar 22, 2024
@fabrice-rossi
Add a LaTeX format for draw (issue #66).
88a9437
fabrice-rossi added a commit that referenced this issue Mar 23, 2024
@fabrice-rossi
Add support of UTF8 symbols (issue #66).
17cd2c5
fabrice-rossi added a commit that referenced this issue Mar 23, 2024
@fabrice-rossi
Renamed ascii to text for utf8 integration (issue #66).
51f0fda
fabrice-rossi added a commit that referenced this issue Mar 23, 2024
@fabrice-rossi
Add UTF-8 based representation for the context tree (issue #66).
4e219f6
@fabrice-rossi fabrice-rossi mentioned this issue Mar 23, 2024
Merged
@fabrice-rossi fabrice-rossi linked a pull request Mar 23, 2024 that will close this issue
Add UTF-8 support to draw functions #74
Merged
@fabrice-rossi fabrice-rossi mentioned this issue Mar 29, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Add UTF-8 support to draw functions fabrice-rossi/mixvlmc
1 participant
@fabrice-rossi