Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): PR template #7857

Merged
merged 2 commits into from Apr 5, 2022
Merged

chore(): PR template #7857

merged 2 commits into from Apr 5, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Apr 3, 2022

Created a PR template with a notice regarding a PR lockdown for the migration.
Needless to say I shall be enforcing this lockdown on myself as of now 馃槓 (Well maybe just one more rtl fix).

馃槄

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.18 |    76.54 |   86.24 |    82.9 |                                               
 fabric.js |   83.18 |    76.54 |   86.24 |    82.9 | ...,29966,30091,30171-30236,30359,30458,30694 
-----------|---------|----------|---------|---------|-----------------------------------------------

Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.13 |    76.55 |   86.23 |   82.85 |                                               
 fabric.js |   83.13 |    76.55 |   86.23 |   82.85 | ...,29958,30083,30163-30228,30351,30450,30686 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 added the CI/CD label Apr 4, 2022
@ShaMan123 ShaMan123 merged commit 3aa6280 into master Apr 5, 2022
@ShaMan123 ShaMan123 deleted the git-pr-temp branch April 5, 2022 11:50
@ShaMan123
Copy link
Contributor Author

@ShaMan123
Copy link
Contributor Author

This does work

https://github.com/fabricjs/fabric.js/compare/master...abc?quick_pull=1&template=pull_request_template.md

maybe you need to configure something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants