Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(): PR template #7857

Merged
merged 2 commits into from
Apr 5, 2022
Merged

chore(): PR template #7857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e723885
Create pull_request_template.md
ShaMan123 Apr 3, 2022
304dd2f
Update pull_request_template.md
ShaMan123 Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
---
name: Pull Request
about: Creating a PR

---

<!--
Hi there!
Thanks for taking the time and putting the effort into making fabric better! 💖
Take a look at ./CONTRIBUTING.md for crucial instructions regarding local setup, testing etc.
https://github.com/fabricjs/fabric.js/blob/master/CONTRIBUTING.md

Adding tests that verify your fix and safegurad it from unwanted loss and changes is a MUST.

PRing is not always simple, don't hestitate to ask for help (beware of 'em gotchas 😓).
We appreciate your effort and would like the process to be productive and enjoyable.
A strong community means a strong and better product for everyone.
-->


<!--
📣 IMPORTANT NOTICE - PR LOCKDOWN 🔒 04/2022
We are excited to announce that fabric is migrating to modern typescript/javascript 🤩.
This means we will ⛔ not be accepting any PRs out of scope with the migration.
We understand this might be annoying but wasted work is ever more so.
The migration will be extreme on the source code so PRs from before will probably become stale to the point of death after the migration.
It hurts us the throw away good work, effort and time put into fabric so please stay patient.
You are welcome to join the migration effort 🔨
https://github.com/fabricjs/fabric.js/issues/7596
ShaMan123 marked this conversation as resolved.
Show resolved Hide resolved

If you remain strong minded about PRing and the fix is small you can submit a PR to the 5.x branch
During the migration we will port these changes to master
-->



## Motivation
<!-- Why you are proposing -->
<!-- You can use the @closes notation to mark issues that will be resolved by this PR -->

## Description
<!-- What you are proposing -->

## Changes
<!-- before the fix vs. after -->

## Gist
<!-- Technical stuff if necessary -->

## In Action
<!-- Show case your accomplishment -->
<!-- Upload screenshots, screencasts and live examples showing your fix in contrast to the current state -->