fix(Control): corner coords definition order #9884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
I think this is good, it also somehow aligns it with getCoords that returns an array in the same 'order' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control.calcCornerCoordsreturns corners in an order which make them an incorrect polygon, whereas it should just be a rect. That's becauseblis defined beforebr.Since ES2015 object keys are returned in insertion-order by spec (https://stackoverflow.com/a/23202095/6860493) so I believe we should fix this in
calcCornerCoordsinstead of manually sorting the coords before callingIntersection.isPointInPolygon. That's more convenient and it works correctly out-of-the-box.If you revert the fix, you'll see the test failing.