bump minimum python version to 3.10 #2349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
saitcakmak
approved these changes
Apr 11, 2024
|
@sdaulton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
==========================================
+ Coverage 94.91% 94.92% +0.01%
==========================================
Files 491 495 +4
Lines 47788 48057 +269
==========================================
+ Hits 45356 45620 +264
- Misses 2432 2437 +5 ☔ View full report in Codecov by Sentry. |
|
@sdaulton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
May 25, 2024
Summary: A few changes were needed to enable Python 3.12 in tests: * I unpinned the pyfakefs version. * I removed Yappi entirely. Yappi was used to print basic profiling output on test runtime when tests timed out. It seems to be incompatible with unittest.mock with Python 3.12; see here: sumerc/yappi#172 I don't think anyone was using Yappi's output. Note: This previously did not work when facebook#2349 was put in due to an issue with pyzmq, but since then there have been new pyzmq releases, which added 3.12 support. Differential Revision: D57815360
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
May 25, 2024
Summary: A few changes were needed to enable Python 3.12 in tests: * I unpinned the pyfakefs version. * I removed Yappi entirely. Yappi was used to print basic profiling output on test runtime when tests timed out. It seems to be incompatible with unittest.mock with Python 3.12; see here: sumerc/yappi#172 I don't think anyone was using Yappi's output. Note: This previously did not work when facebook#2349 was put in due to an issue with pyzmq, but since then there have been new pyzmq releases, which added 3.12 support. Differential Revision: D57815360
facebook-github-bot
pushed a commit
that referenced
this pull request
May 25, 2024
Summary: Pull Request resolved: #2478 A few changes were needed to enable Python 3.12 in tests: * I unpinned the pyfakefs version. * I removed Yappi entirely. Yappi was used to print basic profiling output on test runtime when tests timed out. It seems to be incompatible with unittest.mock with Python 3.12; see here: sumerc/yappi#172 I don't think anyone was using Yappi's output. Note: This previously did not work when #2349 was put in due to an issue with pyzmq, but since then there have been new pyzmq releases, which added 3.12 support. Reviewed By: Balandat Differential Revision: D57815360 fbshipit-source-id: 4c40fcde516034e1c6065e45c37f9d3110bd2b78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump minmum python version to 3.10 since scientific python is no longer supporting py3.9: https://scientific-python.org/specs/spec-0000/