Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump minimum python version to 3.10 #2349

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.9"
python-version: "3.10"
- name: Install dependencies
# Pin ufmt deps so they match intermal pyfmt.
run: |
Expand All @@ -50,7 +50,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.9"
python-version: "3.10"
- name: Install dependencies
env:
ALLOW_BOTORCH_LATEST: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.9"
python-version: "3.10"
- name: Install dependencies
env:
ALLOW_BOTORCH_LATEST: true
Expand All @@ -70,7 +70,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.9"
python-version: "3.10"
- name: Install dependencies
env:
ALLOW_BOTORCH_LATEST: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.9"
python-version: "3.10"
- name: Install dependencies
run: |
# use stable Botorch
Expand All @@ -51,7 +51,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.9"
python-version: "3.10"
- name: Install dependencies
run: |
# use stable Botorch
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.9", "3.11"]
python-version: ["3.10", "3.11"]
fail-fast: false

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable_tutorials.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.9"
python-version: "3.10"

- if: ${{ inputs.pinned_botorch }}
name: Install dependencies with pinned BoTorch
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ artificial evaluation function):
## Installation

### Requirements
You need Python 3.9 or later to run Ax.
You need Python 3.10 or later to run Ax.

The required Python dependencies are:

Expand Down
4 changes: 2 additions & 2 deletions ax/service/utils/best_point.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
from ax.plot.pareto_utils import get_tensor_converter_model
from ax.utils.common.logger import get_logger
from ax.utils.common.typeutils import checked_cast, not_none
from numpy import NaN
from numpy import nan
from torch import Tensor

logger: Logger = get_logger(__name__)
Expand Down Expand Up @@ -735,7 +735,7 @@ def _is_all_noiseless(df: pd.DataFrame, metric_name: str) -> bool:
name_mask = df["metric_name"] == metric_name
df_metric_arms_sems = df[name_mask]["sem"]

return ((df_metric_arms_sems == 0) | df_metric_arms_sems == NaN).all()
return ((df_metric_arms_sems == 0) | df_metric_arms_sems == nan).all()


def _derel_opt_config_wrapper(
Expand Down
2 changes: 1 addition & 1 deletion docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: Installation
---

## Requirements
You need Python 3.9 or later to run Ax.
You need Python 3.10 or later to run Ax.

The required Python dependencies are:

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def setup_package() -> None:
],
long_description=long_description,
long_description_content_type="text/markdown",
python_requires=">=3.9",
python_requires=">=3.10",
install_requires=REQUIRES,
packages=find_packages(),
package_data={
Expand Down
Loading