Test against Python 3.12 #2478
Closed
Test against Python 3.12 #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2478 +/- ##
==========================================
+ Coverage 95.26% 95.28% +0.01%
==========================================
Files 485 485
Lines 47424 47408 -16
==========================================
- Hits 45178 45171 -7
+ Misses 2246 2237 -9 ☔ View full report in Codecov by Sentry. |
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
esantorella
force-pushed
the
test_against_312
branch
from
f71029f
to
6b49f30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57815360 |
Summary: A few changes were needed to enable Python 3.12 in tests: * I unpinned the pyfakefs version. * I removed Yappi entirely. Yappi was used to print basic profiling output on test runtime when tests timed out. It seems to be incompatible with unittest.mock with Python 3.12; see here: sumerc/yappi#172 I don't think anyone was using Yappi's output. Note: This previously did not work when facebook#2349 was put in due to an issue with pyzmq, but since then there have been new pyzmq releases, which added 3.12 support. Differential Revision: D57815360
esantorella
force-pushed
the
test_against_312
branch
from
6b49f30
to
998b93d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57815360 |
|
This pull request has been merged in ba6eb81. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This did not work when #2349 was put in due to an issue with pyzmq. Let's see if it works now that there have been a couple new pyzmq releases.