Incorrect matching on files with multiple dots

[sandyarmstrong]

If you have a file like "Company.Project.sln" or "archive.tar.gz", the highlighting and file name matching are incorrect. For example, fpp highlight and try to execute a command on "Project.sln" or "tar.gz".

[pcottle]

Hey @sandyarmstrong

I can't seem to reproduce this -- we definitely allow multiple periods in the filename:

Can you perhaps provide some example input or a solid repro?

Note that we have separate regex for files that dont have a directory prepended to them (aka stuff like echo.py):
https://github.com/facebook/PathPicker/blob/master/src/parse.py#L30

but we have to be a lot more restrictive with that regex since we dont want to match JS code like:

data.object.some.field

(closing for now, reopen if you have the repro). a lot of this pain would go away if we simply checked if the file exists...

[sandyarmstrong]

Your example only works because you provided an absolute path. It fails with relative paths. For example:

touch ~/banana.Project.sln
cd ~
echo banana.Project.sln | fpp
ls | fpp

Then you'll see the bad matching. I've tested with latest master.

[sandyarmstrong]

Fixed in 3792357.