Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Overflow should make the Rapid button narrow too #1500

Closed
bhousel opened this issue Aug 1, 2024 · 1 comment
Closed

Check Overflow should make the Rapid button narrow too #1500

bhousel opened this issue Aug 1, 2024 · 1 comment
Labels
feature-mobile Issue or request related to Rapid on mobile/touch devices
Milestone

Comments

@bhousel
Copy link
Contributor

bhousel commented Aug 1, 2024

We have this nifty function checkOverflow in the UISystem which can check if we are overflowing the toolbars, and if so, class them as narrow so that the button labels can hide.

checkOverflow(selector, reset) {
if (reset) {
delete this._needWidth[selector];
}
const selection = this.context.container().select(selector);
if (selection.empty()) return;

It works pretty well, but we don't make the Rapid button narrow and we should.
Basically, just need to swap to a version of the Rapid logo without the wordmark next to it.

resize buttons

@bhousel bhousel added the feature-mobile Issue or request related to Rapid on mobile/touch devices label Aug 1, 2024
bhousel added a commit that referenced this issue Aug 1, 2024
(closes #1500)

This also introduces a `uichange` event emitted from our UiSystem, which
allows other parts of the code to watch for changes like this.

Using this event to tell the Rapid button to rerender,
also using this in the photo viewer code (it was previously called directly on resize)
@bhousel
Copy link
Contributor Author

bhousel commented Aug 1, 2024

Done 💪

resize buttons2

@bhousel bhousel added this to the v2.4 milestone Aug 1, 2024
@bhousel bhousel closed this as completed in 853c3bd Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-mobile Issue or request related to Rapid on mobile/touch devices
Projects
None yet
Development

No branches or pull requests

1 participant