Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap #485

Closed
Bonkles opened this issue Jun 28, 2022 · 3 comments
Closed

Minimap #485

Bonkles opened this issue Jun 28, 2022 · 3 comments
Labels
top-priority Top priority issue
Milestone

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Jun 28, 2022

The minimap is now available using the hotkey forward slash /.

The border has been updated a bit since v1 to soften its edges.
Image

Its operation is nearly the same as the old one- except that on pan, the viewfield doesn't update.

@Bonkles Bonkles changed the title Get Minimap working Minimap Jun 28, 2022
@Bonkles Bonkles closed this as completed Aug 2, 2022
@Bonkles Bonkles added this to the v2 Alpha milestone Aug 9, 2022
@bhousel
Copy link
Contributor

bhousel commented Feb 1, 2023

Its operation is nearly the same as the old one- except that on pan, the viewfield doesn't update.

I'd like to reopen this because I think having the viewfield rectangle stay fixed while the imagery moves under it is a pretty important feature - this allows the user to actually use the minimap to focus on some part of the map.

  • fix viewfield rectange

minimap v1

minimap v1

minimap v2 beta

minimap v2 beta

Also noticing some minor visual issues:

  • Locator overlay texture disappears sometimes? It might be the code that removes locator overlay when map is loaded (this is a thing that should happen on the main map only)
  • Actually we should probably scale down all the textures used? This was an issue with the old map too. Basically - we are displaying the overlay images that are designed for a normal sized map. This image shows kind of what I mean:

Screenshot 2023-02-01 at 2 46 29 PM

@bhousel bhousel reopened this Feb 1, 2023
@bhousel bhousel added the v2.beta label Feb 1, 2023
@bhousel bhousel added top-priority Top priority issue and removed v2.beta labels Apr 8, 2023
bhousel added a commit that referenced this issue Apr 20, 2023
- now there is a single Map for storing the textureData
- add refcounts alongside each managed texture

I think refcounting should fix the issue with the "disappearing overlay texture"
mentioned here #485 (comment)
We're showing the tiles in 2 places so need to be much smarter about freeing them
from the atlas

Also the refcounting can be useful for the text label atlas,
which IIRC just fills up with labels and never frees them.
@bhousel bhousel removed this from the v2 Alpha 2 milestone Jan 10, 2024
@bhousel
Copy link
Contributor

bhousel commented Apr 15, 2024

I'd like to reopen this because I think having the viewfield rectangle stay fixed while the imagery moves under it is a pretty important feature - this allows the user to actually use the minimap to focus on some part of the map.

I fixed this viewfield issue sometime around 3cbb638

@bhousel bhousel added this to the v2.3 milestone Apr 18, 2024
@bhousel
Copy link
Contributor

bhousel commented Apr 18, 2024

  • Actually we should probably scale down all the textures used? This was an issue with the old map too. Basically - we are displaying the overlay images that are designed for a normal sized map.

Fixed this in 061854d by just.. always rounding up to the next integer zoom instead of rounding to nearest. This results in always fetching slightly sharper images than we need, rather than sometimes displaying blurry images. We'll see how this performs.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
top-priority Top priority issue
Projects
Status: Pending Release
Development

No branches or pull requests

2 participants