Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI suggest snapping, but no snapping occurs #689

Closed
mvexel opened this issue Dec 5, 2022 · 2 comments
Closed

UI suggest snapping, but no snapping occurs #689

mvexel opened this issue Dec 5, 2022 · 2 comments
Assignees

Comments

@mvexel
Copy link
Contributor

mvexel commented Dec 5, 2022

Description

In point (node) drawing mode, when hovering over the halo of an area feature, the UI suggests that a point drawn at that moment will snap to the area outline, however, the point appears in the interior, no snapping occurs.

ssss.mov

Version

2.00-alpha3

What browser are you seeing the problem on? What version are you running?

Firefox 107 Mac

Steps to reproduce

  1. Enter point drawing mode
  2. Hover over the halo of an area feature
  3. Click to draw the point

The browser URL at the time you encountered the bug

https://mapwith.ai/rapid-v2-alpha3#background=EsriWorldImagery&datasets=fbRoads,msBuildings&disable_features=boundaries&map=21.50/40.74004/-111.86053

@Bonkles Bonkles self-assigned this Dec 13, 2022
@Bonkles
Copy link
Contributor

Bonkles commented Dec 14, 2022

Whew! Okay, some discussion here.

First, I have just cleaned up the snapping as best as I can for the mapathon this friday (whoo). The renderer will no longer get confused about whether it is targeting a parent way or area during a node dragging operation.

Note: Node snapping works a little funkily at the moment. I have filed #719 to track this. Basically, we need to rethink how we do our polygon rendering and targeting. There's more information there.

For now, you should be able to snap nodes to ways as normal, and areas will only 'snap' once you hover over the area fill. Like so:

node_dropping_onto_fill.mov

Downside- in wireframe mode, this means nothing is targetable! But that will get fixed in #719 as well.

@Bonkles
Copy link
Contributor

Bonkles commented Dec 14, 2022

Fixed in d72e896fb9289e6695eec6f38d2a169f8c9d8ca1. Incidentally this made the behavior of the fix for #702 even better- the way/area you're modifying will no longer 'flicker' as you drag the node around.

@Bonkles Bonkles closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pending Release
Development

No branches or pull requests

2 participants