-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change snap target of areas from fills to outlines. #719
Labels
Comments
bhousel
added a commit
that referenced
this issue
Feb 8, 2023
see #719 For now, don't detect a snap-to-way unless it's very close to the way. A more permanent solution would be to draw the fills and edges separately and be able to detect them in the drawing code.
I've added a bunch of workarounds in the code that should mostly prevent snapping if the click too far away from the shape's edge. I'll leave the issue open, hoping to add a less hacky fix later. |
bhousel
added a commit
that referenced
this issue
Mar 2, 2023
see #719 For now, don't detect a snap-to-way unless it's very close to the way. A more permanent solution would be to draw the fills and edges separately and be able to detect them in the drawing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the renderer for polygons draws both an outline and an area fill. The fill depends on whether we are using wireframe mode, partial fill mode, or full-fill mode:
area_fills.mov
As of right now- only the fills are targetable for node snapping. This needs to be changed- we should allow only the outlines to be snapped/connected to, but that's not ready yet.
Here's an example of what this looks like when trying to add a new node to a polygon:
node_dropping_onto_fill.mov
The behavior here is not intuitive- the node is being snapped to the edge of the polygon since RapiD thinks the way is being 'snapped' to.
The text was updated successfully, but these errors were encountered: