Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change snap target of areas from fills to outlines. #719

Open
Bonkles opened this issue Dec 14, 2022 · 1 comment
Open

Change snap target of areas from fills to outlines. #719

Bonkles opened this issue Dec 14, 2022 · 1 comment
Labels
bug Something isn't working top-priority Top priority issue

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Dec 14, 2022

Currently, the renderer for polygons draws both an outline and an area fill. The fill depends on whether we are using wireframe mode, partial fill mode, or full-fill mode:

area_fills.mov

As of right now- only the fills are targetable for node snapping. This needs to be changed- we should allow only the outlines to be snapped/connected to, but that's not ready yet.

Here's an example of what this looks like when trying to add a new node to a polygon:

node_dropping_onto_fill.mov

The behavior here is not intuitive- the node is being snapped to the edge of the polygon since RapiD thinks the way is being 'snapped' to.

@Bonkles Bonkles added the beta label Dec 14, 2022
@Bonkles Bonkles added this to the v.next milestone Dec 14, 2022
@bhousel bhousel added the bug Something isn't working label Jan 16, 2023
bhousel added a commit that referenced this issue Feb 8, 2023
see #719

For now, don't detect a snap-to-way unless it's very close to the way.
A more permanent solution would be to draw the fills and edges separately and
be able to detect them in the drawing code.
@bhousel
Copy link
Contributor

bhousel commented Feb 8, 2023

I've added a bunch of workarounds in the code that should mostly prevent snapping if the click too far away from the shape's edge. I'll leave the issue open, hoping to add a less hacky fix later.

bhousel added a commit that referenced this issue Mar 2, 2023
see #719

For now, don't detect a snap-to-way unless it's very close to the way.
A more permanent solution would be to draw the fills and edges separately and
be able to detect them in the drawing code.
@bhousel bhousel added top-priority Top priority issue and removed v2.beta labels Apr 8, 2023
@bhousel bhousel removed this from the v.next milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working top-priority Top priority issue
Projects
Status: Triage
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants