This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BuildCommand: the default result is an error
Summary: The current logic and implementation may result that in SimpleConsole (with `-c ui.superconsole=DISABLED`) a failure may be reported as a success first and then as a true failure. This can happen because `BuildCommand`: 1. assumes SUCCESS as an initial status 2. doesn't handle all exceptions 3. issues a build finished `event` in the finally block `params.getBuckEventBus().post(BuildEvent.finished(started, exitCode));` This change ensures that for `buck build` success will be reported only if it was a real success Reviewed By: ttsugriy fbshipit-source-id: 2c40ce9
- Loading branch information