java_binary: manifest_file rejects target name as input

[davido]

Nothing is more disappointing than unfulfilled expectations:

genrule(
  name = 'manifest',
  cmd = 'echo "foo: bar" > $OUT',
  out = 'MANIFEST.MF',
)

java_binary(
  name = 'app',
  main_class = 'please.fix.Me',
  manifest_file = ':manifest',
  deps = [':manifest'],
)

fails here on most recent master:

$ buck build //:app
Using buckd.
[-] PARSING BUILD FILES...FINISHED 0,1s
[+] BUILDING...0,0s
java.lang.RuntimeException: Failed to coerce field named: manifestFile, Not an ordinary file: ':manifest'.
    at com.facebook.buck.rules.ParamInfo.set(ParamInfo.java:130)
[...]

[shs96c]

I've a diff out for review on this. Will update this issue once it's bee okayed.

[shs96c]

Fixed in 1ac479f

[davido]

@shs96c Thanks! You forgot to mention this issue in the commit message ;-)