Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Invalid character ':' in temp file name on other platform #265

Closed
davido opened this issue Mar 2, 2015 · 0 comments
Closed

Invalid character ':' in temp file name on other platform #265

davido opened this issue Mar 2, 2015 · 0 comments

Comments

@davido
Copy link
Contributor

davido commented Mar 2, 2015

On most recent master (c0e4e2f) buck build is failing here with: http://paste.openstack.org/show/185497/

This diff fixed it here:

diff --git a/src/com/facebook/buck/rules/CachingBuildEngine.java b/src/com/facebook/buck/rules/CachingBuildEngine.java
index e87bea7..47f1857
--- a/src/com/facebook/buck/rules/CachingBuildEngine.java
+++ b/src/com/facebook/buck/rules/CachingBuildEngine.java
@@ -424,7 +424,8 @@ public class CachingBuildEngine implements BuildEngine {
     // that we are creating a zip-based FileSystem.
     File zipFile;
     try {
-      zipFile = File.createTempFile(rule.getFullyQualifiedName().replace('/', '_'), ".zip");
+      String tmp = rule.getFullyQualifiedName().replace('/', '_').replace(':', '-');
+      zipFile = File.createTempFile(tmp, ".zip");
     } catch (IOException e) {
       throw new RuntimeException(e);
     }

@sdwilsh sdwilsh closed this as completed in b28b366 Mar 5, 2015
openstack-gerrit pushed a commit to openstack-infra/gerrit that referenced this issue Mar 9, 2015
Most recent version fixed critical bugs that prevent Gerrit build on
other platform: [1], [2].

[1] facebook/buck#248
[2] facebook/buck#265

Change-Id: Ie283140a73967ba763c13a78abe6ff04183ed480
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant