This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Make sure python_test runs outside of the Buck project. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `python_test` rules depended on a system property ("buck.home") that
was never set. As such, any time a `python_test` ran outside of the main
buck tree, it would fall back to `user.dir`. Obviously, this never would
not exist in a majority of projects, causing `python_test` to fail.
Tested manually on the gerrit repo after a version bump.
The `python_test` rules depended on a system property ("buck.home") that
was never set. As such, any time a `python_test` ran outside of the main
buck tree, it would fall back to `user.dir`. Obviously, this never would
not exist in a majority of projects, causing `python_test` to fail.
Tested manually on the gerrit repo after a version bump.
|
Merged manually. |
|
@shs96c updated the pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
python_testrules depended on a system property ("buck.home") thatwas never set. As such, any time a
python_testran outside of the mainbuck tree, it would fall back to
user.dir. Obviously, this never wouldnot exist in a majority of projects, causing
python_testto fail.Tested manually on the gerrit repo after a version bump.