Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Update D8 to version 1.5.41 #2276

Closed
wants to merge 1 commit into from
Closed

Conversation

kageiit
Copy link
Contributor

@kageiit kageiit commented Jun 4, 2019

No description provided.

@kageiit kageiit changed the title Update d8 to version 1.5.41 Update D8 to version 1.5.41 Jun 4, 2019
@kageiit
Copy link
Contributor Author

kageiit commented Jun 4, 2019

cc @styurin

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miaoyipu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@justinjhendrick
Copy link
Contributor

Sorry for the delay. We've seen some tests fail on this pull request and we're debugging it now.

@kageiit
Copy link
Contributor Author

kageiit commented Jun 12, 2019

Sorry for the delay. We've seen some tests fail on this pull request and we're debugging it now.

Any updates here?

@justinjhendrick
Copy link
Contributor

ping @thezhangwei, any progress on the D8 1.5.41 + redex type erasure issues?

@justinjhendrick
Copy link
Contributor

D8 is removing some annotations that Redex depends on. We think this commit is the source of that behavior: https://r8.googlesource.com/r8/+/162711c22d03eb5699080e8f6301477c22322e29%5E%21/

@kageiit
Copy link
Contributor Author

kageiit commented Jun 18, 2019

We could make the fork in buck retain the annotations for now if thats needed for redex

@justinjhendrick
Copy link
Contributor

@kageiit, could you send me an email at jhendrick at fb. We have some ideas about D8, Buck, and Redex integration that I'd like to include you in.

@kageiit kageiit closed this Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants