This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
make buck Python3 compatible #2391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@v-jizhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@v-jizhang has updated the pull request. Re-import the pull request |
|
@v-jizhang has updated the pull request. Re-import the pull request |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 28, 2020
Summary: The function attributes named func_X have been renamed to use the __X__ form in Python3, https://docs.python.org/3/whatsnew/3.0.html#operators-and-special-methods and also built-in changes https://wiki.python.org/moin/Python3.0#Built-In_Changes. The old names can't be used in Python3. This PR changes the old names to new names to make buck Python3 compatible. Python2 was EOL on 1/1/2020, Homebrew/homebrew-core#49796. Pull Request resolved: #2391 Reviewed By: philipjameson, v-jizhang Pulled By: v-jizhang shipit-source-id: c00dae81ea0e0356ebacb2429ddee26bb8fe9362
This was referenced Mar 18, 2020
v-jizhang
added a commit
that referenced
this pull request
Mar 30, 2020
Summary: The function attributes named func_X have been renamed to use the __X__ form in Python3, https://docs.python.org/3/whatsnew/3.0.html#operators-and-special-methods and also built-in changes https://wiki.python.org/moin/Python3.0#Built-In_Changes. The old names can't be used in Python3. This PR changes the old names to new names to make buck Python3 compatible. Python2 was EOL on 1/1/2020, Homebrew/homebrew-core#49796. Pull Request resolved: #2391 Reviewed By: philipjameson, v-jizhang Pulled By: v-jizhang shipit-source-id: c00dae81ea0e0356ebacb2429ddee26bb8fe9362
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function attributes named func_X have been renamed to use the X form in Python3, https://docs.python.org/3/whatsnew/3.0.html#operators-and-special-methods and also built-in changes https://wiki.python.org/moin/Python3.0#Built-In_Changes.
The old names can't be used in Python3.
This PR changes the old names to new names to make buck Python3 compatible.
Python2 was EOL on 1/1/2020, Homebrew/homebrew-core#49796.