This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Remove @Nullable annotation from escapeJavaType method
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `type` parameter is annotated with `@Nullable`, but the parameter should not actually be null because it is being dereferenced within the method. Remove the annotation. Test Plan: Run some test builds. Change-Id: I0605bea537a60525921c4d9f5d162e8702d2ed0c
|
Merged as 033e616. |
|
@dpursehouse updated the pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
typeparameter is annotated with@Nullable, but the parametershould not actually be null because it is being dereferenced within
the method.
Remove the annotation.
Test Plan:
Run some test builds.
Change-Id: I0605bea537a60525921c4d9f5d162e8702d2ed0c