Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support application version via env variable #2762

Closed
miraage opened this issue Jul 11, 2017 · 1 comment
Closed

Support application version via env variable #2762

miraage opened this issue Jul 11, 2017 · 1 comment

Comments

@miraage
Copy link

miraage commented Jul 11, 2017

I assume this is a pretty common case to display application version somewhere. For reproducing the bugs, QA purposes and so on. If you ask me there is no concise way to put application version to the bundle, except duplicating it somewhere.
I think REACT_APP_VERSION variable name suits the needs. On the other hand, this variable will be defined implicitly, which is not very clear for the developer unless he always reads notes/docs.
I'm ready to provide a PR if you agree.

@Timer
Copy link
Contributor

Timer commented Jul 13, 2017

This will be covered by #2468; thanks though!

@Timer Timer closed this as completed Jul 13, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants