refactor(theme-classic): clean up CSS of doc sidebar item (#6622)

* refactor(theme-classic): clean up doc sidebar item CSS * Use link placeholder for Introduction category * Use test pages for dogfooding * Update sidebars.js * Add another test case
facebook · Feb 11, 2022 · cfef475 · cfef475
1 parent da90751
commit cfef475
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 34 deletions.
diff --git a/packages/docusaurus-theme-classic/src/theme/DocSidebarItem/index.tsx b/packages/docusaurus-theme-classic/src/theme/DocSidebarItem/index.tsx
@@ -162,8 +162,6 @@ function DocSidebarItemCategory({
           className={clsx('menu__link', {
             'menu__link--sublist': collapsible && !href,
             'menu__link--active': isActive,
-            [styles.menuLinkText]: !collapsible,
-            [styles.hasHref]: !!hrefWithSSRFallback,
           })}
           onClick={
             collapsible

diff --git a/packages/docusaurus-theme-classic/src/theme/DocSidebarItem/styles.module.css b/packages/docusaurus-theme-classic/src/theme/DocSidebarItem/styles.module.css
@@ -6,18 +6,6 @@
  */
 
 @media (min-width: 997px) {
-  .menuLinkText {
-    cursor: initial;
-  }
-
-  .menuLinkText:hover {
-    background: none;
-  }
-
-  .menuLinkText.hasHref {
-    cursor: pointer;
-  }
-
   .menuHtmlItem {
     padding: var(--ifm-menu-link-padding-vertical)
       var(--ifm-menu-link-padding-horizontal);

diff --git a/packages/docusaurus-theme-classic/src/theme/DocSidebarItems/styles.module.css b/packages/docusaurus-theme-classic/src/theme/DocSidebarItems/styles.module.css
diff --git a/website/_dogfooding/docs-tests-sidebars.js b/website/_dogfooding/docs-tests-sidebars.js
@@ -40,6 +40,15 @@ const sidebars = {
       collapsible: false,
       items: ['index', 'more-test'],
     },
+    {
+      type: 'category',
+      label: 'Another category with index',
+      collapsible: false,
+      link: {
+        type: 'generated-index',
+      },
+      items: ['more-test'],
+    },
     {
       type: 'category',
       label: 'Huge sidebar category',
@@ -74,6 +83,8 @@ const sidebars = {
     {
       type: 'category',
       label: 'HTML items tests',
+      collapsed: false,
+      collapsible: false,
       items: [
         //  title
         {