Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): fix algolia search container bug #10164

Merged
merged 1 commit into from
May 23, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 23, 2024

Motivation

The Algolia search container does not need to be added/removed constantly. This lead to a bug where onOpen would recreate it but onInput wouldn't so the modal does not actually show when typing chars while the Algolia button is focused.

Fix #10162

Test Plan

https://deploy-preview-10164--docusaurus-2.netlify.app/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label May 23, 2024
@slorber slorber requested a review from Josh-Cena as a code owner May 23, 2024 10:19
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 23, 2024
Copy link

netlify bot commented May 23, 2024

[V2]

Name Link
🔨 Latest commit 427daa1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/664f183920b95f0008b6c946
😎 Deploy Preview https://deploy-preview-10164--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 70 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 72 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 68 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

Size Change: -1 B (0%)

Total Size: 1.72 MB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/codeTranslations.json 2 B 0 B
website/.docusaurus/docusaurus.config.mjs 26.9 kB 0 B
website/.docusaurus/globalData.json 107 kB 0 B
website/.docusaurus/i18n.json 930 B 0 B
website/.docusaurus/registry.js 275 kB 0 B
website/.docusaurus/routes.js 179 kB 0 B
website/.docusaurus/routesChunkNames.json 119 kB 0 B
website/.docusaurus/site-metadata.json 2.17 kB 0 B
website/build/assets/css/styles.********.css 112 kB 0 B
website/build/assets/js/main.********.js 854 kB -1 B (0%)
website/build/index.html 38.1 kB 0 B

compressed-size-action

@slorber slorber merged commit 0ce7c13 into main May 23, 2024
34 checks passed
@slorber slorber deleted the slorber/fix-algolia-search-container-bug branch May 23, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page loses scrollbar when using Algolia search bar
2 participants