feat: add custom commit message #1136
Conversation
Addresses: facebook#1135
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for docusaurus-preview ready! Built with commit 82519a8 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
v1/lib/publish-gh-pages.js
Outdated
| @@ -165,9 +166,10 @@ fs.copy( | |||
|
|
|||
| shell.cd(path.join('build', `${PROJECT_NAME}-${DEPLOYMENT_BRANCH}`)); | |||
| shell.exec('git add --all'); | |||
|
|
|||
|
|
|||
| const commitMessage = CUSTOM_COMMIT_MESSAGE ? CUSTOM_COMMIT_MESSAGE : 'Deploy website' | |||
There was a problem hiding this comment.
const commitMessage = CUSTOM_COMMIT_MESSAGE || 'Deploy website'
| @@ -162,8 +162,17 @@ Now, whenever a new commit lands in `master`, CircleCI will run your suite of te | |||
|
|
|||
| ### Tips & Tricks | |||
|
|
|||
| When initially deploying to a `gh-pages` branch using Circle CI, you may notice that some jobs triggered by commits to the `gh-pages` branch fail to run successfully due to a lack of tests. You can easily work around this by creating a basic Circle CI config with the following contents: | |||
| When initially deploying to a `gh-pages` branch using Circle CI, you may notice that some jobs triggered by commits to the `gh-pages` branch fail to run successfully due to a lack of tests (This can also result in chat/slack build failure notifications). | |||
There was a problem hiding this comment.
Add the chat/slack build notifications to pickup on commonly searched google terms
|
@endiliey added to v2 and some docs. Ran prettier. |
Addresses: #1135. Looking for early feedback.
Motivation
See #1135
Have you read the [Contributing Guidelines on pull requests]
Yes
Test Plan
Testing happen as part of deploy, could not find additional unit tests.
Related PRs
Docs in this PR