Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom commit message on publish #1135

Closed
jakebolam opened this issue Dec 1, 2018 · 0 comments
Closed

Support for custom commit message on publish #1135

jakebolam opened this issue Dec 1, 2018 · 0 comments

Comments

@jakebolam
Copy link
Contributor

jakebolam commented Dec 1, 2018

🚀 Feature

Having a custom commit message on publish, would allow people to add commit messages such as:

  • [skip ci] to prevent circleci attempting to build the branch

Motivation

Want to use circleci, this repo has:

  • Greenkeeper
  • Docusaurus
  • Alerting on failed builds

Greenkeeper requires the setting 'build all branches' in circleci
When a publish happen gh-pages triggers a build, that fails as it has no .circleci file.
Having a custom commit message e.g. [skip ci] would prevent this build happening.

Pitch

I'm happy to put up a PR for this.

I see that the facebook project add's a no-op circleci config file to prevent builds running on gh-pages: https://github.com/facebook/Docusaurus/blob/master/v1/website/static/.circleci/config.yml

jakebolam added a commit to jakebolam/Docusaurus that referenced this issue Dec 1, 2018
endiliey pushed a commit that referenced this issue Dec 4, 2018
* feat: add custom commit message

Addresses: #1135

* Update publish-gh-pages.js

* add support to v2 as well

* docs: add them

* docs
@endiliey endiliey closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants