fix: mobile navigation should show deepest breadcrumb instead of outermost #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 0c61eee |
|
Deploy preview for docusaurus-preview ready! Built with commit 0c61eee |
hong4rc
changed the title
subcategory if it is exist for title of navsubcategory if it is exist for title of nav
endiliey
changed the title
subcategory if it is exist for title of nav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixed #1338
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Test with
testing-library's website.Live preview in https://hongarc.github.io/testing-library-docs/
docsin nav-sitetoggle of navclick one item inDOM Testing LibraryBefore:
After:
It shows subcategory's title if it is a subcategory
and keep
category's title if it is a category