Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): improve UI of search #2001

Merged
merged 1 commit into from
Nov 16, 2019
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 16, 2019

Motivation

Minor UI corrections in the search bar - remove underline on hover, uniform background for the columns (always white), fix overlapping dropdown menu on search input in mobile. See test plan for details.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before After
image image
Before After
image image

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 16, 2019
@yangshun yangshun merged commit 4c7de3b into facebook:master Nov 16, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 0d459be

https://deploy-preview-2001--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 0d459be

https://deploy-preview-2001--docusaurus-preview.netlify.com

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 16, 2019
@lex111
Copy link
Contributor Author

lex111 commented Nov 16, 2019

Wow, a very fast merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants