Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix browser window menu icon on smaller screen #2002

Merged
merged 1 commit into from
Nov 16, 2019

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 16, 2019

Motivation

On small screens (<360px), the browser window menu icon goes beyond the parent container.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before After
image image

@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 16, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 16, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 078e0e4

https://deploy-preview-2002--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 078e0e4

https://deploy-preview-2002--docusaurus-preview.netlify.com

@lex111
Copy link
Contributor Author

lex111 commented Nov 16, 2019

@yangshun ⚠️ on the same small screens, the width of the sidebar is expanded to full screen and there is no way to close the sidebar! This is strange because there is no such problem on https://infima-dev.netlify.com/

image

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah because the mobile nav width has a hardcoded value of 350. I have a task to make it vw-based.

@yangshun yangshun merged commit 79f3b95 into facebook:master Nov 16, 2019
@endiliey
Copy link
Contributor

endiliey commented Nov 17, 2019

https://infima-dev.netlify.com is outdated btw. dont use that site anymore 😆. Use https://facebookincubator.github.io/infima/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants