refactor(v2): move unused generated files out from build folder #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
added
the
pr: maintenance
|
Deploy preview for docusaurus-2 ready! Built with commit e032222 |
|
Deploy preview for docusaurus-preview ready! Built with commit e032222 |
yangshun
approved these changes
Nov 24, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
chunk-map and client-manifest.json is actually not useful in build folder. We shouldn't put it in build folder, but put it in generated folder instead.
The benefit of this is that less space is used for build artifacts. (eg: if pushing to github pages or aws-bucket, these files are not uploaded)
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
dev chunk map still working
its now moved to generated dir
