fix(v2): clean generated manifest from previous build so we dont use the wrong one #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
changed the title
yangshun
approved these changes
Nov 27, 2019
|
Deploy preview for docusaurus-2 ready! Built with commit 1a9d3dd |
|
Deploy preview for docusaurus-preview ready! Built with commit 1a9d3dd |
endiliey
added
pr: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix from regression in #2033
Because client and server compilation is async, sometimes we can mistakenly reuse the manifest from previous build, which is wrong.
Now i remember why I put it in
buildfolder previously although its not used later on for end-user, because its cleaned up on every buildHave you read the Contributing Guidelines on pull requests?
yes
Test Plan
All CI should pass
Try build locally several times, manifest is used correctly